[Webkit-unassigned] [Bug 30324] Console shows no repeat count when repeatedly logging an Event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 15:22:58 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30324


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41509|review?                     |review-
               Flag|                            |




--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2009-10-20 15:22:58 PDT ---
(From update of attachment 41509)
>              && (this.url == msg.url)
> -            && (this.message == msg.message);
> +            && (this.message == msg.message)
> +            && (this.repeatCount > msg.repeatCount);

This does not look right: messages are equal when their properties are equal,
whereas this check should be made external. We are already handle isEqual in
InspectorController, I don't think we should do it in the frontend as well.
They way I would solve it is following: Split
InspectorFrontend::addMessageToConsole into
InspectorFrontend::addConsoleMessage(msg) and
InspectorFrontend::updateConsoleMessageCount(count). Call latter when you
increment count from inspector controller; Nuke this isEqual you are modifying
as a whole.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list