[Webkit-unassigned] [Bug 30304] struct RGBA32Buffer is twice as big as the old ImageData of Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30304





--- Comment #10 from Holger Freyther <zecke at selfish.org>  2009-10-19 19:42:13 PDT ---
(In reply to comment #8)
> (In reply to comment #7)
> >      RGBA32Buffer& buffer = m_frameBufferCache[frameIndex];
> 
> I fully support changing this too!  Never even saw it.
> 
> (That said, there is one difference -- in this function, members of |buffer|
> get set and called, but |buffer| is never used directly as an lvalue, whereas
> assigning to a ref looks more like an assignment to a temp.  But I think this
> distinction is pretty trivial, and doesn't justify one case over the other.)

How would you change it? Going for pointers?

RGA32Buffer* buffer = &m_frameBuffer..
buffer->setFoo(foo);

IntRect* rect = &m_Rects
rect->operator=(*newRect);
*rect = *newRect?

or make frameIndex const in the method body and use m_rects[frameIndex] =
newRect?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.