[Webkit-unassigned] [Bug 30304] struct RGBA32Buffer is twice as big as the old ImageData of Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30304


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41032|review?                     |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-10-19 14:22:52 PDT ---
(From update of attachment 41032)
I've never seen WebKit use this style before:
 IntRect& rect = m_rects[frameIndex];
 272     rect = frameRect;

I think we should either abstract that into a function call where it is OK to
pass a &, or we should use explicit m_rects[frameIndex] = calls.  Or maybe it
would be OK wiht a better variable name than "rect".

I really think pkasting is your best reviewer, even if he's not technically a
reviewer yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.