[Webkit-unassigned] [Bug 30473] Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 19 13:48:01 PDT 2009


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #41349|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-10-19 13:47:59 PDT ---
(From update of attachment 41349)
+        No new tests. (OOPS!)

the OOPS will cause the commit to fail.  The one in "reviewed by" is OK,
because the commit-queue will substitute in the right thing.  BUt the no new
tests line should be replaced by something explaingin why this does not need
testing or why testing is impossible.

Something simple like:

Build fix only, no tests possible.

would be fine.

cq- since the commit-queue can't handle this as-is.  If you post a new patch 
w/o the second OOPS! that can be r+/cq+'d though.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list