[Webkit-unassigned] [Bug 30520] Enable creation of custom SidebarTreeElements for different ProfileTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30520





--- Comment #4 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2009-10-19 13:10:55 PDT ---
(In reply to comment #3)
> > +    _viewForProfile: function(profile)
> > +    {
> > +        for (var key in this._profilesIdMap) {
> > +            if (this._profilesIdMap[key] === profile) {
> > +                var parsedKey = this._parseKey(key);
> > +                if (parsedKey)
> > +                    return this.getProfileType(parsedKey[1]).viewForProfile(profile);
> 
> This sounds much more complex than "profile.type.viewForProfile(profile)".
> Should we make profile have this property in order to get rid of key parsing?

Good point. I was trying to decrease coupling as much as possible but this one
seems fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.