[Webkit-unassigned] [Bug 30526] Supporting multiple OS X versions in one binary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30526


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41439|review?                     |review-
               Flag|                            |




--- Comment #2 from Mark Rowe (bdash) <mrowe at apple.com>  2009-10-19 13:06:34 PDT ---
(From update of attachment 41439)
It may appear to work but it will have subtle bugs as *all* of the code wrapped
with these macros was written with the assumption that the code within these
blocks was targeted for the specific OS version.  When building in the manner
you mention it will be running on a different version of the OS and may not
behave as expected.  A number of aspects of the code would likely need to be
updated to determine the underlying OS version at runtime and to react
accordingly.

It also doesn’t make sense to switch a single use of BUILDING_ON_TIGER and
BUILDING_ON_LEOPARD to using availability macros.  If we’re going to make this
change it needs to be done in a more consistent manner.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.