[Webkit-unassigned] [Bug 29999] [GStreamer] Should handle unknown duration better

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29999


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|                            |FIXED
                 CC|                            |jmalonzo at gmail.com
             Status|UNCONFIRMED                 |RESOLVED




--- Comment #7 from Jan Alonzo <jmalonzo at gmail.com>  2009-10-19 04:58:52 PDT ---
(In reply to comment #6)
> (From update of attachment 40785 [details])
> 
> > +    if (!gst_element_query_duration(m_playBin, &timeFormat, &timeLength) ||
> > +        timeFormat != GST_FORMAT_TIME ||
> > +        timeLength == GST_CLOCK_TIME_NONE) {
> 
> We don't normally break the expression into multiple lines. I'll fix it up when
> landing.
> 
> Is it possible to test this or is this covered by our existing tests already?
> 
> r=me.

Landed as http://trac.webkit.org/changeset/49774

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.