[Webkit-unassigned] [Bug 30354] [Qt] Plugins : QGVLauncher crashes on exit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30354


Holger Freyther <zecke at selfish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41374|review?                     |review+
               Flag|                            |




--- Comment #10 from Holger Freyther <zecke at selfish.org>  2009-10-19 02:54:08 PDT ---
(From update of attachment 41374)

>  QWebView::~QWebView()
>  {
> -    if (d->page)
> +    if (d->page) {
>          d->page->d->view = 0;
> +        d->page->d->client = 0;
> +    }

As discussed on IRC this might have a bad side effect if someone is doing.

view1->setPage(page)
view2->setPage(page)
delete view1;

but we want to solve it by adding a warning to QWebView::setPage.


> +    if (html.contains("</embed>")) {
> +        QTest::qWait(2000); // some reasonable time for the PluginStream to feed test.swf to flash
> +    }

I fear our coding style guidelines wants you to omit the curly braces here.
This needs to be fixed when landing. In general it would be nice if we could
wait for things like QEvent::UpdateRequest, QEvent::ShowEvent instead of the
qWait but in practive we can not. It is making the test a bit fragile but I see
it is the best we can do right now.

I'm leaving the commit-queue to "?" as this test wants a resource introduced by
another patch and the patch needs a tweak.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.