[Webkit-unassigned] [Bug 30380] [Qt] Windowed Plugins : Crash when using QWebPage without a QWebview (i.e no QWebPageClient)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30380





--- Comment #9 from Girish Ramakrishnan <girish at forwardbias.in>  2009-10-19 02:13:59 PDT ---
>From https://bugs.webkit.org/show_bug.cgi?id=30354#c6, 
(In reply to comment #6)
> +        In addition, setFrameRect()/updatePluginWidget() is called even if the
> +        plugin was not succesfully loaded. So, a status check is added to 
> +        setNPWindowIfNeeded.
> 
> Maybe it makes more sense adding the (m_status !=
> PluginStatusLoadedSuccessfully) there then? Currently with your patch it is not
> obvious why you have that test.
> 

updatePluginWidget() updates the windowrect among other things. We can use this
for painting, if we wanted to paint plugins that didn't load successfully. The
intent is that we don't want to call setwindow since the plugin never loaded.
So, setNPWindowIfNeeded seems correct.

> you could make it a separate 'if' and add a comment explaining why that is
> done.

Agree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.