[Webkit-unassigned] [Bug 30354] [Qt] Plugins : QGVLauncher crashes on exit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 18 22:10:37 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30354





--- Comment #8 from Girish Ramakrishnan <girish at forwardbias.in>  2009-10-18 22:10:37 PDT ---
(In reply to comment #6)
> +        In addition, setFrameRect()/updatePluginWidget() is called even if the
> +        plugin was not succesfully loaded. So, a status check is added to 
> +        setNPWindowIfNeeded.
> 
> Maybe it makes more sense adding the (m_status !=
> PluginStatusLoadedSuccessfully) there then? Currently with your patch it is not
> obvious why you have that test.
> 
> you could make it a separate 'if' and add a comment explaining why that is
> done.

Looks like you interchanged comments. This comment is meant for #30380 :-). I
will reply on that task.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list