[Webkit-unassigned] [Bug 30354] [Qt] Plugins : QGVLauncher crashes on exit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 18 08:51:52 PDT 2009


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |kenneth at webkit.org

--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-10-18 08:51:52 PDT ---
+        In addition, setFrameRect()/updatePluginWidget() is called even if the
+        plugin was not succesfully loaded. So, a status check is added to 
+        setNPWindowIfNeeded.

Maybe it makes more sense adding the (m_status !=
PluginStatusLoadedSuccessfully) there then? Currently with your patch it is not
obvious why you have that test.

you could make it a separate 'if' and add a comment explaining why that is

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list