[Webkit-unassigned] [Bug 25413] [GTK] Please expose the level of headings.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25413





--- Comment #4 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-10-17 03:56:23 PDT ---
Thanks for the feedback, Xan!

Notes (mostly to myself so that I remember them after I get some sleep. :-) )

> WebKit style guide tells us to use C++ style castings, so you need to do
> something like:
> 
> AtkAttribute* attribute =
> static_cast<AtkAttribute>(g_malloc(sizeof(AtkAttribute)));

When I try that I get an error:

~~~~~~
WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: In function
‘AtkAttributeSet* addAttributeToSet(AtkAttributeSet*, const char*, const
char*)’:
WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:179: error: no
matching function for call to ‘_AtkAttribute::_AtkAttribute(void*)’
~~~~~~

But I'm new to C++. I bet if I research it and think about it, it'll all become
clear. I'll do that "tomorrow."

> - Is the (const char*) casting for "level" really needed? I think it should be
> const char* already.

You are correct. My bad.

> - Using returnString() here is a tiny hack, since the function was really
> intended for return values in public APIs implementations. Do thinks work if
> you pass value.utf8().data() to the function?

They do indeed. Cool.

> I'm marking it as r- while we work on those final details.

Thanks much for the review! I'll look into the first issue/error after some
sleep. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.