[Webkit-unassigned] [Bug 30362] check-webkit-style is wrong about indent checking in namespaces in header files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 16 09:43:34 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30362


Carol Szabo <carol.szabo at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41291|                            |review?
               Flag|                            |
  Attachment #41179|0                           |1
        is obsolete|                            |




--- Comment #7 from Carol Szabo <carol.szabo at nokia.com>  2009-10-16 09:43:33 PDT ---
Created an attachment (id=41291)
 --> (https://bugs.webkit.org/attachment.cgi?id=41291)
Proposed Patch

This addresses Levin's comments.
I have run the check-webkit-style scripth before and after my changes through
the entire WebKit source and I have spot checked issues. At the moment other
than the scenario described earlier in the comments, which I understand not to
be a favored code style anyway, I saw no false warnings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list