[Webkit-unassigned] [Bug 30369] Fix media layout test file ordering so both branded and unbranded builds of Chromium will pass layout tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 16 05:06:21 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30369


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




--- Comment #8 from Xan Lopez <xan.lopez at gmail.com>  2009-10-16 05:06:21 PDT ---
This commit breaks a lot of tests in the GTK+ port. I'm not too familiar with
this, but I think that since we support both ogg and mp4 we are exiting this
loop :

    for (var i = 0; i < codecs.length; ++i) {
        if (element.canPlayType(codecs[i][0]))
            return name + "." + codecs[i][1];
    }

in findMediaFile on the first try (which is now 'video/ogg'), which makes us
fail the test since 'video/mp4' is expected.

Any solution for this? We are struggling to make our bots green, but if we find
20 more tests failing each day when we wake up I don't see any light at the end
of the tunnel ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list