[Webkit-unassigned] [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server

Thu Oct 15 23:12:50 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=27490

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41268|review?                     |review+
               Flag|                            |

--- Comment #33 from David Levin <levin at chromium.org>  2009-10-15 23:12:50 PDT ---
(From update of attachment 41268)
Thanks for addressing my comments even though you are basically importing a 3rd
party project into WebKit.

I think there are only a few things relevant to this review:
1. Is the license compatible with WebKit?
Yes, it is BSD.

2. Does this module implement something useful to WebKit?
After reviewing it, it appears to correctly implement the server side of Web
Sockets which is useful for testing. (And there have been other reviews in the
external project.)

3. Is it possible to integrate this into the layout test run without having
every developer/machine install something?
Yes. It will use standalone.py for this.

Given the affirmative answers on these items. It seems like this should go in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.