[Webkit-unassigned] [Bug 28964] [Chromium] ChromiumDataObject should have getter/setter interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28964





--- Comment #17 from Roland Steiner <rolandsteiner at google.com>  2009-10-15 21:10:17 PDT ---
(In reply to comment #16)
> > The main reason for the change is that I want to implement
> > get/setData("text/uri-list") in Chromium.
> > (see https://bugs.webkit.org/show_bug.cgi?id=28293)
> > However, according to the HTML5 spec, "text/uri-list" and "URL" are not
> > independent.
> > So having WebDragData accessing a single 'url' member directly is inconvenient.
> 
> It seems to me that this ^^^ is the only method that should have been added.

Yes, I added the other interface methods mainly for consistency.

> I intended ChromiumDataObject to remain very lightweight since we have it
> replicated in two places already in Chrome: WebDragData and WebDropData.  It
> sucks to have so many layers.

There I wholeheartedly agree! 

> Soon, WebDragData will live in svn.webkit.org, so the justification given in
> comment #0 will go away.  It'll be easy to change the WebKit layer
> implementation (WebDragData.cpp) and the ChromiumDataObject.h in the same
> patch.

As I wrote http://codereview.chromium.org/269091, I didn't know that was the
plan. It'd certainly simplify things.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.