[Webkit-unassigned] [Bug 30343] [v8] typeof(HTMLMediaElement) should return undefined if media engine is not available

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 15 13:59:41 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30343





--- Comment #6 from Andrew Wilson <atwilson at chromium.org>  2009-10-15 13:59:40 PDT ---
I changed window.Audio, and did nothing for HTMLMediaElement or any other
constructors, as I was not aware that this was the desired behavior.

Just returning undefined for the constructor is incorrect - you should instead
follow the example for window.Audio, which actually removes the associated
attribute from the window object.

Case in point: with the patch attached to this bug, "typeof HTMLMediaElement
=== 'undefined'", but "'HTMLMediaElement' in window" would still return true.
If you follow the approach I used for window.Audio, then you'd get the correct
behavior in both cases.

Take a look here:

https://bugs.webkit.org/show_bug.cgi?id=30240

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list