[Webkit-unassigned] [Bug 30333] [Color] (Un)premultiplication code is not optimal and broken in alpha==0 case

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30333





--- Comment #5 from Dirk Schulze <krit at webkit.org>  2009-10-15 09:42:37 PDT ---
(In reply to comment #4)
> Ok, I know how to run the layout tests now but this is really taking far too
> long for such a simply patch. I'll try to write a small testcase for this later
> though.
> 
> Also this code is only used by the cairo backend in a few places, here's the
> relevant code from cairo itself and as you can see it does the same.
> 
> http://cgit.freedesktop.org/cairo/tree/src/cairo-png.c#n53
> http://cgit.freedesktop.org/cairo/tree/src/cairo-png.c#n408

There are already some tests for getImageData and putImageData in
LayoutTests/fast/canvas/
This both calls are mainly using this color-code.

Tests that can help you to figure out if your code works are:
   * canvas-putImageData.html
   * canvas-getImageData.html

But I should warn you. canvas-getImageData might still fail because of bug
22150
It would be a great improvement if some more steps pass on
canvas-getImageData.html.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.