[Webkit-unassigned] [Bug 30232] [HTML5] Add document.head

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30232


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|                            |FIXED
             Status|NEW                         |RESOLVED




--- Comment #16 from Joseph Pecoraro <joepeck at webkit.org>  2009-10-15 00:39:51 PDT ---
Landed in http://trac.webkit.org/changeset/49610
r49610 = a7e5c8e75b5404e71a0a7a6740f2b235f0b338f6

I had to provide a Windows Build Fix: r49611
Landed in http://trac.webkit.org/changeset/49611
Modeled after a previous Windows Build Fix for:
http://trac.webkit.org/changeset/48728

It appears as though there was an issue with Window's Code Generation.  Could
someone enlighten me on why this was necessary, and if this is a problem could
you point me in the right direction for getting this fixed?  Is there someone
who knows a lot about Window's code generation?

The error I was received was:
http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/6292/steps/compile-webkit/logs/stdio
GEN_DOMHTMLEmbedElement.cpp
..\DOMCreateInstance.cpp(207) : error C2259: 'GEN_DOMHTMLDocument' : cannot
instantiate abstract class
        due to following members:
        'HRESULT IGEN_DOMDocument::head(IGEN_DOMHTMLHeadElement **)' : is
abstract
       
C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Include\WebKit/WebKit.h(61160)
: see declaration of 'IGEN_DOMDocument::head'

After adding the build fix Windows passed all the Layout tests, including my
newly added test, which confused me, but maybe that is how it should be?

Sorry about all this for a one line fix!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.