[Webkit-unassigned] [Bug 30362] check-webkit-style is wrong about indent checking in namespaces in header files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 14 12:38:08 PDT 2009


Carol Szabo <carol.szabo at nokia.com> changed:

           What    |Removed                     |Added
  Attachment #41179|                            |review?
               Flag|                            |

--- Comment #1 from Carol Szabo <carol.szabo at nokia.com>  2009-10-14 12:38:08 PDT ---
Created an attachment (id=41179)
 --> (https://bugs.webkit.org/attachment.cgi?id=41179)
Proposed Patch

This patch addresses some of the issues seen with check-webkit-style
It has limited handling of preprocessor directives, thus it may generate a few
false errors when a #if directive with #else clause is used at the end of a
statement such as here:
namespace test {
void f(
    long long int);
    long int);

It will complain about the spacing before the 6th line since it will think that
the function declaration has finished on the 4th line.

But it addresses many false errors about indentation in header files containing
the namespace reserved word. Also it improves handling of spacing around binary

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list