[Webkit-unassigned] [Bug 30328] Web Inspector: Migrate profiles to the injected script-based schema.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30328


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41153|review?                     |review-
               Flag|                            |




--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2009-10-14 01:41:58 PDT ---
(From update of attachment 41153)
> +    void getProfileHeaders(long callId);
> +    void getProfile(long callId, unsigned uid);

These should be private in InspectorController.

> +        function profileCallback(profile) {
> +            self.profile = profile;
> +            continueInitialization();
> +        }

{ on next line

> +        if (!this.profile._isStub)

Why do you end up with profiles in different states? I think you should resolve
profile only here and only once.

Otherwise r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.