[Webkit-unassigned] [Bug 26083] How to access formatted Java script Console message ?

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 15:08:12 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26083


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40070|review?                     |review-
               Flag|                            |




--- Comment #5 from Adam Barth <abarth at webkit.org>  2009-10-13 15:08:12 PDT ---
(From update of attachment 40070)
+ getMessageSourceAndLevelPrefix(source,level,sourceString,levelString);

We need spaces after the commas here.

+ getAllArgumentsAsString(callStack,message);

Here too.

+ void Console::getAllArgumentsAsString(ScriptCallStack* callStack, String&
message)

Please remove leading blank line from this function.

+ if (i==0 && lastCaller.argumentAt(i).jsValue().isString()) {

We need spaces around the ==

There are too many style violations for me to review them all, much less
understand the content of the patch.  Have you run check-webkit-style on your
patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list