[Webkit-unassigned] [Bug 30328] Web Inspector: Migrate profiles to the injected script-based schema.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30328


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41095|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2009-10-13 12:58:04 PDT ---
(From update of attachment 41095)
We now are spending twice as much memory for the profile during serialization.
Do you think we could tweak native object a bit so that it we don't need
additional wrapping?

> +        ScriptFunctionCall function(m_scriptState, m_injectedScriptObj, "serializeProfile");
> +        function.appendArgument(toJS(m_scriptState, it->second.get()));
> +        ScriptValue serializedProfile = function.call();
> +        m_frontend->didGetProfile(callId, serializedProfile);

Could you extract wrapping into a separate method? (I see two usages).

Otherwise looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.