[Webkit-unassigned] [Bug 30135] Make InspectorTimelineAgent consistent with other components in Inspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30135


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41117|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2009-10-13 12:40:16 PDT ---
(From update of attachment 41117)
> -void InspectorBackend::enableTimeline(bool always)
> +void InspectorBackend::enableTimeline()
>  {

If you are implementing profiler-alike operation, you should consider naming
these accordingly. In the profiler world start/stopProfiling are the methods
controlling profiler. enable/disableProfiler methods are only making sure JS
engine is ready for the operation as a whole. I think you should name yours
start/stopTimelineProfiler or similar. Note that you won't find
start/stopProfiling methods in the inspector controller API since they are not
used anywhere other than Web Inspector frontend. That's why they only present
in InspectorBackend interface. There are start/stopUserInitiatedProfiling
methods that inspector controller exposes to the clients instead. It is up to
you whether to expose start/stopTimelineProfiler methods in InspectorController
API or limit their visibility to the frontend.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.