[Webkit-unassigned] [Bug 30333] [Color] (Un)premultiplication code is not optimal and broken in alpha==0 case

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30333


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41101|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2009-10-13 08:46:43 PDT ---
(From update of attachment 41101)
Thanks for this contribution!

The change seems OK, but we need a test case that demonstrates the effects this
has. We don't take bug fixes without test cases. So please add a test case
demonstrating the effect this has. One way to create a test case may be to use
the <canvas> element, because that supports reading back pixel values from the
canvas buffer.

LayoutTests/fast/canvas/script-tests/set-colors.js is an example of a test case
that might be adaptable to test this behavior.

An alternative would be to explain why no test case is possible. That seems
unlikely, though.

Also, you need to run all existing tests and generate new results for any tests
that now will have different results.

review- because there is no test case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.