[Webkit-unassigned] [Bug 30308] [GStreamer] Add direct support for ARGB videos

Tue Oct 13 01:09:56 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=30308

Sebastian Dröge <slomo at circular-chaos.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41093|                            |review?
               Flag|                            |
  Attachment #41048|0                           |1
        is obsolete|                            |

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org>  2009-10-13 01:09:55 PDT ---
Created an attachment (id=41093)
 --> (https://bugs.webkit.org/attachment.cgi?id=41093)
0001-Add-support-for-ARGB-videos.patch

New patch that does this, fixes code style at some places and adds some
comments everywhere.
There's also an explanation why I don't use the code from Color.

It's now all done from the streaming thread and not from the main thread, to
only do the necessary bits from the main thread and not block it just because
of the ARGB conversion.

Note: the premultiplication in Color is not optimal IMO, instead of always
rounding upwards it should round to nearest. See also
http://cgit.freedesktop.org/cairo/tree/src/cairo-png.c#n408
My code rounds to nearest too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.