[Webkit-unassigned] [Bug 30170] Qt Plugins : Remove usage of winId()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30170





--- Comment #12 from Girish Ramakrishnan <girish at forwardbias.in>  2009-10-13 00:24:39 PDT ---
(In reply to comment #10)
> (From update of attachment 41031 [details])
> Great cleanup!
> 
> >      case NPNVnetscapeWindow: {
> >          void* w = reinterpret_cast<void*>(value);
> > -        *((XID *)w) = m_parentFrame->view()->hostWindow()->platformPageClient()->winId();
> > +        QWebPageClient* client = m_parentFrame->view()->hostWindow()->platformPageClient();
> > +        *((XID *)w) = client ? client->ownerWidget()->window()->winId() : 0;
> >          return NPERR_NO_ERROR;
> 
> I really hope that this works as expected, especially with flash. Where we
> previously returned
> the windowid of the QWebView here we now return the toplevel ID, which is
> according to spec but
> may not be what the plugin expects.

According to https://developer.mozilla.org/En/NPN_GetValue, "NPNVnetscapeWindow
 - Unix/X11: Gets the browser toplevel window in which the plug-in is
displayed; returns Window"

But really, the point of this patch was not to fix that :-) It was
unintentional, the new patch, which I am uploading removed the 'window()' part.

Also, I checked with both windowed and windowless. NPNVnetscapeWindow is never
queried. So it's dead code, atleast for flash.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.