[Webkit-unassigned] [Bug 30245] [Chromium] Decoration of "search" input field is wrongly rendered

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 23:31:54 PDT 2009


--- Comment #5 from Yuta Kitamura <yutak at chromium.org>  2009-10-12 23:31:54 PDT ---
(In reply to comment #3)
> (From update of attachment 40933 [details])
> Where can I see the resulting rendered image of the new search box?


> Style:
>  154         IntRect calcParentBoxOfSearchFieldItem(RenderObject* o, const
> IntRect& r);
> calc is a strange abbreviation.  Normally we use full english words, although
> "calc" might be OK.

Sure. I'll update the patch accordingly.

> Again, full words are generally preferred over letters:
>  392     IntRect bounds = r;
> You're trying to get the content rect of the parent box in the grandparent's
> coordinates?  I feel like there is an easier way to do that...

We need to find the *drawing position* of parent box. Since the coordinate is
relative to the current layer (created by -webkit-transform), it's not same as
the absolute position. I tried to find more adequate way to calculate this but
I could not. Suggestions are welcome.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list