[Webkit-unassigned] [Bug 30170] Qt Plugins : Remove usage of winId()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30170


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41031|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #10 from Simon Hausmann <hausmann at webkit.org>  2009-10-12 22:36:52 PDT ---
(From update of attachment 41031)
Great cleanup!

>      case NPNVnetscapeWindow: {
>          void* w = reinterpret_cast<void*>(value);
> -        *((XID *)w) = m_parentFrame->view()->hostWindow()->platformPageClient()->winId();
> +        QWebPageClient* client = m_parentFrame->view()->hostWindow()->platformPageClient();
> +        *((XID *)w) = client ? client->ownerWidget()->window()->winId() : 0;
>          return NPERR_NO_ERROR;

I really hope that this works as expected, especially with flash. Where we
previously returned
the windowid of the QWebView here we now return the toplevel ID, which is
according to spec but
may not be what the plugin expects.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.