[Webkit-unassigned] [Bug 30318] ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 19:15:16 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30318


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41076|review?                     |review+
               Flag|                            |




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2009-10-12 19:15:16 PDT ---
(From update of attachment 41076)
> I see the original change did not remove this code, is there a reason to keep
> it?

I just wanted to keep this potential behavior change separate form other
changes in that patch. Thanks for following up on this!

> it's impossible to create a Node w/o a pointer to Document

That's not entirely accurate; see DOMImplementation::createDocumentType() for
the one and only case when this happens. Maybe you could test for that before
landing (and compare to Firefox), but it's unlikely that there is any harm in
such a change.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list