[Webkit-unassigned] [Bug 30318] New: ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30318

           Summary: ScriptExecutionContext is not anymore needed to create
                    an EventListener - remove old code.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dimich at chromium.org
                CC: ap at webkit.org


Change http://trac.webkit.org/changeset/48884 removed the need to have
ScriptExecutionContext to create an EventListener - rather it is pulled from
EventTarget at the moment of event handling.
It seems we can remove the code in custom add/removeEventListener methods that
retrieves the context which is no longer used. The potential change in behavior
here is that in case the EventTarget has null context it wasn't adding a
listener and now it would, which could later be invoked if the EventTarget will
gain context, so it could change the behavior of some page, theoretically. But
I don't think this scenario ever realizes. For example, it's impossible to
create a Node w/o a pointer to Document and while a Node may change documents
during its life, there is no code that can set the Node::m_document to null.

I see the original change did not remove this code, is there a reason to keep
it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.