[Webkit-unassigned] [Bug 18994] LANG/LC_ALL influences the result of element.style.opacity

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18994





--- Comment #72 from Darin Adler <darin at apple.com>  2009-10-12 12:51:07 PDT ---
(In reply to comment #69)
> > I'd like to see test cases for the edge cases of this code. I worry that this
> > will do the wrong thing for extremely large and extremely small numbers -- test
> > cases could make it clear that the behavior hasn't changed, or that it has
> > improved.
> 
> The opacity-float test changes try to.  Was there anything else you had in
> mind?  Or do you mean testing the failure cases -- when the values exceed the
> allowed inputs?

My approach would be to have tests at the various boundaries: highest value
that works, lowest that does not work, that sort of thing. Make sure all the
code paths are tested, even the less important ones.

I think we're OK. Not sure. I didn't re-review the tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.