[Webkit-unassigned] [Bug 30225] window.location.href needlessly decodes URI-encoded characters in the URI path
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 12 09:27:30 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=30225
--- Comment #8 from Andrei Popescu <andreip at google.com> 2009-10-12 09:27:29 PDT ---
(In reply to comment #7)
> (In reply to comment #6)
> > I looked and, if I am right, then the String conversion operator of KURL should
> > be enough, so I do not need to add anything new. This operator calls
> > KURL::string(), which just returns the string that was the output of the parse
> > method. So simply removing the call to prettyURL in Location.cpp seems to do
> > the job and all the layout tests pass.
>
> Sounds good.
>
> The way to prove this is with tests. Think about cases where you think this
> might fail, and write a new test or tests that covers as many cases as
> possible. At least one test for each distinct thing prettyURL used to do, and
> also tests based on guesses you might have about what could go wrong. And then
> make sure you run the tests in other browsers too.
I was just about to upload a new patch but I will hold off for now and add more
tests. Thanks for the comments!
Andrei
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list