[Webkit-unassigned] [Bug 30281] LayoutTests/fast/cookies/local-file-can-set-cookies.html fails when cookies for document already exist

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 09:21:58 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30281


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40998|review?                     |review+
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2009-10-12 09:21:57 PDT ---
(From update of attachment 40998)
This is OK, but if we're going to change the test like this I also suggest that
the test do this before setting document.cookie:

    shouldBe("document.cookie.indexOf('ppkcookie1=testcookie')", "-1");

To make sure we are actually setting the cookie. I'll do r=me like this, but
you could consider my suggestion.

I also suggest making per-file comments in change log.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list