[Webkit-unassigned] [Bug 29997] [GStreamer] Prevent double-memcpy in GStreamer media player

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29997


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gns at gnome.org




--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2009-10-12 06:16:03 PDT ---
(In reply to comment #4)

> So, the surface *to* which we're painting is still ARGB32. Only the GStreamer
> video sink only accepts non-alpha RGB, which means that you can still do nice
> alpha effects with the video but not from inside the GStreamer pipeline. (Note:
> almost no video format supports ARGB)
> 
> But I plan to add ARGB32 support to the video sink after you accepted my two
> patches. This will be quite inefficient because GStreamer and Cairo have other
> conventions for ARGB but for the rare case where you have alpha-content in the
> GStreamer pipeline it will preserve the alpha.
> 
> (Too much information?)

I guess I was able to get it, thanks for explaining!

> Ok... PARNumerator would be fine too? I mean, everybody who should touch this
> code should know what PAR means... and pixelAspectRatio is a long word ;)

yeah, I know, but we have much longer variable names in WebKit =D. I think
PARNumerator is fine, though, given that PAR is a concept everyone touching the
code should grasp, as you pointed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.