[Webkit-unassigned] [Bug 30304] New: struct RGBA32Buffer is twice as big as the old ImageData of Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 04:27:56 PDT 2009


           Summary: struct RGBA32Buffer is twice as big as the old
                    ImageData of Qt
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zecke at selfish.org

The RGBA32Buffer takes more space than required and more space than the old
ImageDecoderQt::ImageData. The proposed change is to change the object layout
and move properties only useful for the GIF decoder into the gif decoder. This
change reduces the size of the struct from 52 byte to 20 byte with a byte spare
for future use.

The setRect method of RGBA32Buffer is only useful for animations (currently
only used for GIF). There is no use to store the IntSize of the image and then
again in the IntRect (taking 16bytes). Move the IntRect into into the GIF
decoder and remove setRect from the other decoders.

The two enum values for FrameStatus and FrameDispoal take four byte each, with
the current size of the enum it should not take more than four bits in total.
Propose to change it to uint8_t with a COMPILE_ASSERT to verify that the enum
stays below 256 values.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list