[Webkit-unassigned] [Bug 30271] [QT] DRT doesn't support double click simulation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 11 20:45:32 PDT 2009


--- Comment #5 from Charles Wei <charles.wei at torchmobile.com.cn>  2009-10-11 20:45:32 PDT ---
Thanks for the review , Jakub.

The new patch addresses your comments about a double click event will be
generated with 2 different button clicks, which is incorrect. 

About your other comments 

"Resetting m_timeStarted to false in LTC::reset() may make sense too. In theory
running two (or more) subsequent tests that do not move the mouse position and
simulate two single clicks would create a double click event in the second

I don't agree with that .

1. class LayoutTestController and EventSender are two totally different classes
which don't have any connection , it makes no sense to reset EventSender inside

2. EventServer,  as an Javascript object,  will be instantiated for each test
page,  two or more subsequent tests will each has its own instance of
EventSender,  so mouse clicks in 2 test cases won't create a double click event
in the second test, instead,  2 single-clicks will be created , one for each
test case .


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list