[Webkit-unassigned] [Bug 30274] HistoryController should point back to FrameLoader not Frame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 11 20:28:40 PDT 2009


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #40988|review?                     |review+
               Flag|                            |

--- Comment #3 from Darin Adler <darin at apple.com>  2009-10-11 20:28:40 PDT ---
(From update of attachment 40988)
I think this is OK either way.

Pointing back to the frame is OK because everybody points back to the frame.
It's all one big frame-lifetime-associated family of objects.

Pointing back to the frame loader is OK because the frame loader is the
immediate owner of the history controller, and it's the thing the creates and
destroys the history controller.

I have a hard time getting strong feelings either way.

The part I don't like is functions that are only needed once per page on the
main frame that exist here on a pre-frame object.

r=me, and you can decide whether or not to land this. I really have no

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list