[Webkit-unassigned] [Bug 30267] New: editing\pasteboard\paste-xml.xhtml should not be skipped for windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30267

           Summary: editing\pasteboard\paste-xml.xhtml should not be
                    skipped for windows
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: victorw at chromium.org
                CC: darin at apple.com


Hi Darin,

I am investigating why "editing\pasteboard\paste-xml.xhtml" fails
and is skipped on windows. It looks to me the window's result is
correct while the mac version is different because of a workaround.

This layout test is skipped because of the patch that creates a
fast path for ReplaceSelectionCommand:
Here is the patch: http://trac.webkit.org/changeset/42549
see comments in LayoutTests/platform/win/Skipped.

The patch only applies to simple text pastes, so pasting xml is
handled differently in mac and windows code.

Looking into the _documentFragmentFromPasteboard method in
WebKit/WebView/WebHTMLView.mm, it appears this is because
mac uses a workaround when pasting xml. It checks whether a
doc is HTMLDocument if paste type is RTF, and creates a
DocumentFragment from text if it is an XML doc.

Per comments in the code, _hasHTMLDocument clause is a workaround
for a bug in NSAttributedString: Radar 5052369. There is a "FIXME" on
removing the check once bug 5052369 is fixed.

Since you creates the original test, I would like to check with
you before I make any changes.
-. Should the mac version be changed to not pasting as simple
   text in this case? any update on Radar 5052369? My understanding
   is I can't see the bug details from outside of Apple.
-. I think the windows result is correct, we should remove it from
   skipped list regardless whether or not to keep the mac workaround.

Let me know your thoughts and whether I miss anything.

Thanks,
Victor

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.