[Webkit-unassigned] [Bug 29890] page transition may crash webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29890





--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2009-10-09 14:17:16 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=40962)
 --> (https://bugs.webkit.org/attachment.cgi?id=40962) [details] [details]
> > proposed fix
> 
> You seem to give different reasons for this patch in the commit message and in
> the comments? Can this only happen when a load is cancelled or are there
> situations where a resource can be requested when a new load has already
> started? Is it really OK to clean all resources in the place we do it?

The reason is the same, I just explained different aspects of it, maybe I can
rephrase one of them to make it better? Suggestions? So what happens is that
another provisional load has already been started, but one or more resource
loads didn't hit didFinishLoading yet. This doesn't happen if you simple cancel
a load, because the hash table is not cleared by cancelling. This seems to
happen mainly when the transition is caused by an unload handler or inside the
load-finished handler. I think we're clearing the hash table at the correct
spot - when the provisional load starts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.