[Webkit-unassigned] [Bug 5863] feMorphology filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5863


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40956|review?                     |review+
               Flag|                            |




--- Comment #13 from Nikolas Zimmermann <zimmermann at kde.org>  2009-10-09 12:01:19 PDT ---
(From update of attachment 40956)
Wonderful patch, r=me.

Some small style issues:

> +SVGFEMorphologyElement::SVGFEMorphologyElement(const QualifiedName& tagName, Document* doc)
> +    : SVGFilterPrimitiveStandardAttributes(tagName, doc)

Use "document" instead of "doc", old legacy code uses abbrevations here.
> +    interface [Conditional=SVG&FILTERS, GenerateConstructor] SVGFEMorphologyElement : SVGElement,
> +                                                          SVGFilterPrimitiveStandardAttributes {
Please line up SVGElement & SVGFilterPrimitiveStandardAttributes.

> -        PassRefPtr<FEMorphology> create(FilterEffect*, MorphologyOperatorType, const float&, const float&);  
> +        static PassRefPtr<FEMorphology> create(FilterEffect*, MorphologyOperatorType, float, float);  
Please specify parameter names for the floats.

> -        FEMorphology(FilterEffect*, MorphologyOperatorType, const float&, const float&);
> +        FEMorphology(FilterEffect*, MorphologyOperatorType, float, float);
Ditto.

Please fix before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.