[Webkit-unassigned] [Bug 30246] Factor HistoryController out of FrameLoader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30246





--- Comment #14 from Adam Barth <abarth at webkit.org>  2009-10-09 10:52:14 PDT ---
> Elsewhere you removed the word "history" from the phrase "history item" since
> this is the history controller. I think you should do that here too. Except
> maybe there's ambiguity with back/forward item?

Will do.

> You can consider in some cases including the entire class as a member of the
> owner class.

I did this originally, but I ran into costness problems.  For example, the
history access can't be const any more, but it's called from some const
methods.  I can fix that with const_cast or mutable, but I wasn't sure which
was the less of the two evils.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.