[Webkit-unassigned] [Bug 30246] Factor HistoryController out of FrameLoader

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 9 09:57:08 PDT 2009


--- Comment #10 from Adam Barth <abarth at webkit.org>  2009-10-09 09:57:07 PDT ---
(From update of attachment 40936)
> Maybe we can come up with another creative way to make
> this brief. Is there a good single word for "current item"?

I'll change this to m_currentItem.

> + HistoryController::clearPrevious
> This seems a bit too low-level to be a good abstraction. Maybe a different name
> would work better? Maybe this is something we can improve after the classes are
> split?

Yeah, I'd like to remove the setCurrent / etc methods, but that required me to
tackle loadItem, which I wanted to defer.  I can change this to
"updateForFrameLoadCompleted" since it's only ever called at that time.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list