[Webkit-unassigned] [Bug 20081] [Qt] Add support for windowless NPAPI plugins

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 9 00:42:08 PDT 2009


--- Comment #59 from Girish Ramakrishnan <girish at forwardbias.in>  2009-10-09 00:42:07 PDT ---
(In reply to comment #58)
> Comparing the calls to plugins in PluginView.cpp and in PluginViewQt.cpp I
> noticed 2 differences and I was wondering if they are intentional
> In PluginView.cpp:
>     JSC::JSLock::DropAllLocks dropAllLocks(<b>JSC::SilenceAssertionsOnly</b>);
>     ...
>     PluginView::setCurrentPluginView(0);
> In PluginViewQt.cpp:
>     JSC::JSLock::DropAllLocks dropAllLocks(<b>false</b>);
> and we never call 
>     PluginView::setCurrentPluginView(0);

It's not intentional. 

I don't know anything about the above code other than it locks js code for
mulithread access. There is no bool argument to dropAllLocks, so it appears
that it is wrong. And setCurrentPluginView(0) is also appears to be needed (I
can't see what it is). I will create patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list