[Webkit-unassigned] [Bug 30223] [LayoutTests][Gtk] Set a common Gtk theme as default and update the results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30223





--- Comment #4 from Zan Dobersek <zandobersek at gmail.com>  2009-10-09 00:35:50 PDT ---
(In reply to comment #2)
> (From update of attachment 40894 [details])
> 
> Also WebKit style is to use 0 instead of NULL for c++ code, although maybe the
> gtk code follows some other style?  check-webkit-style should help identify
> some style issues.
> 

I'll raise a discussion on the irc channel about 0 vs NULL problem. I'll also
see about opening a bug for style cleanup of Gtk port's code.

(In reply to comment #3)
> Maybe consider setting the font names and sizes as well?  But maybe that's a
> different bug.  If you're really loading all of this from GtkSettings you'll
> want to override all of 'em, including cursor-blink etc.

Font families and sizes are taken care of in resetDefaultsToConsistentValues
function, which is called before each test. I don't think overriding any other
setting would do any good, or harm.

If it, however, appears that it should be done, the code should be updated -
moving all of the overrides of GtkSettings into a new function for a better
overview.

> (Is this committable without test rebaselines?  Or are they all baselined to
> Raleigh?)

Rebaselining patch will be attached to this bug asap.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.