[Webkit-unassigned] [Bug 30079] unselectable resources in resource panel

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 13:40:02 PDT 2009


Patrick Mueller <pmuellr at yahoo.com> changed:

           What    |Removed                     |Added
  Attachment #40908|                            |review?
               Flag|                            |
  Attachment #40791|0                           |1
        is obsolete|                            |
  Attachment #40791|review?                     |
               Flag|                            |

--- Comment #11 from Patrick Mueller <pmuellr at yahoo.com>  2009-10-08 13:40:02 PDT ---
Created an attachment (id=40908)
 --> (https://bugs.webkit.org/attachment.cgi?id=40908)
proposed patch 2009/10/08 - a

The ResourceSidebarTreeElements were being created by creating a new <a>
element, and moving all the children in the existing tree element into the new
<a> element, then making the <a> element the only child of the tree element. 
Basically, wrapping the existing tree element content in an <a> element.

The <a> element isn't needed, because selection of the tree element is already
handled by the tree element itself.  The <a> element click handling was being
processed by WebInspector.documentClick(), which was then selecting a
potentially incorrect resource, if multiple resources with the same URL exist
in the resource tree.

The "invisible" CSS class is no longer used by any code in Web Inspector, as
near as I can tell (search through inspector code).

The reason the <a> element was added was to allow the resource elements to
be dragged elsewhere and rendered on the drop target as the URL to resource.
Removing the <a> element nullifies that ability.  Code was added to use HTML5
DnD to perform the same function.

Test case was added with three resource retrievals of the same URL, but
different sorts of invocation - two POSTs with different content, and a GET. 
Without the fix, only one of the three resources was selectable in the UI.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list