[Webkit-unassigned] [Bug 30225] window.location.href needlessly decodes URI-encoded characters in the URI path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30225


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40896|review?                     |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-10-08 12:11:51 PDT ---
(From update of attachment 40896)
You ChangeLog is duplicated.

I don't really like pathRaw(), maybe encodedPath()?  Or should path be
decodedPath()?

fast/dom/Window/Location/location-path-has-is-unmodified.htm is sorta a js
test, except you didn't generate the tempate using make-script-test-wrappers.

Why does this need to be run from onload?  It needs to wait for the iframe to
load?  Will body onload do that?

(If this needs to wait for onload, then it won't work quite right as a js test,
so maybe that's why you ddid it this way.)

+        correctValue = "path%2Dwith-escape%2Dcharacters.html";
+        shouldBe("result", "correctValue");

shouldBeEqualToString("normalizeURL(String(window.frames[0].location.href))",
"path%2Dwith-escape%2Dcharacters.html");
would have been better.

Does this actually need to load a valid resource to work?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.