[Webkit-unassigned] [Bug 30223] [LayoutTests][Gtk] Set a common Gtk theme as default and update the results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 12:06:05 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30223


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40894|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-10-08 12:06:05 PDT ---
(From update of attachment 40894)
Sounds fine to me.  Seems silly to wrap this line when lines just below it have
no wrapping.  WebKit style has no official column width.

Also WebKit style is to use 0 instead of NULL for c++ code, although maybe the
gtk code follows some other style?  check-webkit-style should help identify
some style issues.

looks fine, but cq- for the style oddities.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list