[Webkit-unassigned] [Bug 30229] New: [GTK] Exception control in EventSender is not correct

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 12:00:39 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30229

           Summary: [GTK] Exception control in EventSender is not correct
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: alex at igalia.com


In EventSender.cpp we are controlling the exceptions with lines like this one:

    g_return_val_if_fail((!exception || !*exception),
JSValueMakeUndefined(context));

We should use && instead of ||, and we could even leave (!*exception) if we can
assure the parameter is always initialized.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list