[Webkit-unassigned] [Bug 30200] Move executeScript from FrameLoader to ScriptController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 09:32:29 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30200


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40857|review?                     |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-10-08 09:32:29 PDT ---
(From update of attachment 40857)
Can you first invent a x-platform ScriptController if your'e going to add
duplicate code?

ScriptController

And then ScriptControllerJSC and ScriptControllerV8 which inherit from it?

Or heck, you don't even need them to inherit.  Just add a new
ScriptController.cpp at the root level which has these fixes, and makes sure
both builds include it, no?

Unless this code is not copy/paste and I'm mising something?

r- for adding copy/paste code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list